fix: remove branches filter from pr-review workflow trigger#2804
Closed
RabbiIslamRony wants to merge 2 commits intosovware:developmentfrom
Closed
fix: remove branches filter from pr-review workflow trigger#2804RabbiIslamRony wants to merge 2 commits intosovware:developmentfrom
RabbiIslamRony wants to merge 2 commits intosovware:developmentfrom
Conversation
Member
Author
|
Closing in favor of a clean branch (previous branch accidentally included an unrelated commit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
claude-reviewworkflow usespull_request_targetwithbranches: [development], but the workflow has never triggered on any PR. Thebranchesfilter onpull_request_targetappears to match against the HEAD (feature) branch name rather than the PR's base branch, sodevelopmentnever matches.Fix
Remove the
branches: [development]filter. The workflow is safe without it —pull_request_targetruns in the base repo context with onlycontents: readpermission and checks out a pinned SHA, so no untrusted code can run.Testing
Once this is merged into
development, opening any PR againstdevelopmentshould trigger the Claude Code Review workflow.