improve: add Listing Type field to conditional logic available fields#2813
Open
Armanul46 wants to merge 2 commits intosovware:developmentfrom
Open
improve: add Listing Type field to conditional logic available fields#2813Armanul46 wants to merge 2 commits intosovware:developmentfrom
Armanul46 wants to merge 2 commits intosovware:developmentfrom
Conversation
- Remove listing_type from skipKeys so it appears in the "Select a field" dropdown - Add listing_type to mapFieldKeyToSelector for reliable DOM value reading - Return hardcoded General/Featured options in getValueOptions so a select dropdown renders instead of a free text input - Limit operator options to "is / is not" only (same as privacy_policy) to avoid meaningless operators on a binary radio field Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
listing_type field is not rendered when editing a listing in admin, so any conditions referencing it are stripped during normalize_groups() to keep dependent fields always visible in the admin context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
How to reproduce the issue or how to test the changes
Any linked issues
Fixes #
Checklist