new_installer_*.py: terminal state simplifications#52535
Merged
Conversation
`enter_background`, `handle_continue`, and `should_enter_foreground` exist for POSIX job control: the first two are only reachable from the `SIGTSTP` handler, and the third only applies while headless, which cannot be triggered on Windows. The abstract methods forced `WindowsTerminalState` to implement dead code. Give them no-op defaults and drop the Windows overrides, along with the empty POSIX teardown_output. Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
johnwparent
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enter_background,handle_continue, andshould_enter_foregroundexist for POSIX job control: the first two are only reachable from the
SIGTSTPhandler, and the third only applies while headless, whichcannot be triggered on Windows.
The abstract methods forced
WindowsTerminalStateto implement deadcode. Give them no-op defaults and drop the Windows overrides, along
with the empty POSIX
teardown_output.