Add injectable LOD runtime interfaces#297
Open
promontis wants to merge 3 commits into
Open
Conversation
…ction Allow external LOD traverser and sort provider implementations to be injected via SparkRendererOptions. This enables replacing the built-in WASM worker-based traversal and sorting with custom implementations (e.g. WebGPU compute shaders) without modifying SparkJS itself. Without injection, behavior is completely unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add injectable runtime seams for Spark's LOD and sorting pipeline via
SparkRendererOptions, while preserving current behavior by default.This PR exposes three extension points:
ILodTraverserfor LOD tree traversalISortProviderfor depth sortingILodSchedulerfor deciding how overlapping LOD update requests are handledDefault behavior remains unchanged:
WorkerLodTraverserremains the default traversal implementationWorkerSortProviderremains the default sort implementationDropIfBusyLodSchedulerpreserves Spark's current "drop overlapping LOD updates while busy" behaviorWhy
ILodScheduleris separate:SparkRendererwhile keeping the default path intactThis keeps the public change narrowly scoped and non-breaking while enabling external integrations to inject custom policies, such as:
The interfaces and default implementations are exported from the package root so consumers do not need internal module-path imports.
Validation:
DropIfBusyLodSchedulerdefault behavior