Remove OldSparkRenderer and related classes#322
Open
mrxz wants to merge 2 commits into
Open
Conversation
10 tasks
mrxz
force-pushed
the
remove-old-spark
branch
2 times, most recently
from
21d50ac to
f25150e
Compare
Contributor
|
needs rebase |
Collaborator
Author
Done, rebased this PR as well as the follow-up #335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #321. The bundle effectively included two versions of Spark, the "new" and the "old" one. Since most users are expected to only ever use the new one, the old one should simply be removed. As a consequence two examples showcasing features that are no longer part of Spark have been removed as well. These were already excluded from the example page listing.
If absolutely needed to keep the old files around and distributed through npm, we should really split them off into separate entry points. For example, make them accessible through something like: