Skip to content

Handle race condition when insert id to list #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goneall merged 2 commits into from
Jul 19, 2026
Merged

Handle race condition when insert id to list #437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bba56be
Handle race condition when insert id to list
bact Jul 17, 2026
2982e59
Use atomic computeIfAbsent instead of putIfAbsent
bact Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/main/java/org/spdx/storage/simple/StoredTypedItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,7 @@ public boolean addValueToList(PropertyDescriptor propertyDescriptor, Object valu
} else {
id = NO_ID_ID;
}
idValueMap.putIfAbsent(id, new ArrayList<>());
List<Object> list = idValueMap.get(id);
if (list == null) {
// handle the very small window where this may have gotten removed
list = new ArrayList<>();
idValueMap.putIfAbsent(id, list);
}
List<Object> list = idValueMap.computeIfAbsent(id, key -> new ArrayList<>());
return list.add(value);
} catch (Exception ex) {
throw new SpdxInvalidTypeException("Invalid list type for "+propertyDescriptor);
Expand Down
Loading