fix: playback scans against inactive player - #3
Open
treyturner wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix NFC playback scans when Plexamp is stopped with no active queue.
Direct requests to Plexamp now derive the Plex server identifier from autoplay tags and verify that playback actually creates an active queue before reporting success.
Root cause
The service forwarded
listen.plex.tvautoplay URLs directly to Plexamp’s local companion API. This bypassed two behaviors normally provided by the Plex web client:machineIdentifierfrom the nestedserver://<machine-id>/...URIPlexamp could therefore return HTTP 200 without starting playback, causing the service to log a false success.
Changes
plexamp.py./player/playback/playMediaURLs:server://URI.machineIdentifierwhen absent.commandIDvalues.X-Plex-Client-Identifier.X-Plex-Device-Name.playingorbufferingwith a populated play queue.Playback triggered!and updatelast_urlafter successful verification.unittestsuite.main.Dependencies, public configuration, NFC debounce behavior, and automatic retry behavior remain unchanged.
To run tests
python -m unittest discover -s tests -vpython -m compileall -q main.py plexamp.pyactionlint .github/workflows/tests.ymlAll 12 automated tests pass.
Testing performed
Validated against a live Plexamp instance:
Also completed hardware acceptance: