Skip to content

chore: Adds external plugin suite for WorkloadAttestor#6788

Merged
amartinezfayo merged 3 commits intospiffe:mainfrom
jsnctl:jsnctl/integration-external-workload-attestor
Apr 10, 2026
Merged

chore: Adds external plugin suite for WorkloadAttestor#6788
amartinezfayo merged 3 commits intospiffe:mainfrom
jsnctl:jsnctl/integration-external-workload-attestor

Conversation

@jsnctl
Copy link
Copy Markdown
Contributor

@jsnctl jsnctl commented Mar 25, 2026

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

Adds a further external plugin suite to integration - specifically for WorkloadAttestor on the agent side

Description of change

  • Adds dummy implementation of WorkloadAttestor for integration test coverage
  • Adds int test suite for workload attestor coverage

Which issue this PR fixes

part of #5902

* Implements dummy workload attestor plugin

Signed-off-by: Jason Costello <jason@jsnc.tl>
Signed-off-by: Jason Costello <jason@jsnc.tl>
@amartinezfayo amartinezfayo self-assigned this Mar 31, 2026
Copy link
Copy Markdown
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @jsnctl for this!

@amartinezfayo amartinezfayo added this to the 1.15.0 milestone Apr 8, 2026
@amartinezfayo amartinezfayo added this pull request to the merge queue Apr 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 8, 2026
@jsnctl
Copy link
Copy Markdown
Contributor Author

jsnctl commented Apr 9, 2026

Thanks @amartinezfayo. I couldn't see how the check failed to prevent the merge, but I've updated the branch with the latest changes on main, so perhaps it'll work this time?

@amartinezfayo amartinezfayo added this pull request to the merge queue Apr 10, 2026
Merged via the queue into spiffe:main with commit c261e78 Apr 10, 2026
50 checks passed
@amartinezfayo
Copy link
Copy Markdown
Member

@jsnctl that was a flaky test. This is now merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants