New features - #515
Closed
eduardomozart wants to merge 0 commit into
Closed
Conversation
Collaborator
|
I have to find time to review. However, house renovation and two young kids makes this difficult to schedule. |
Contributor
Author
|
No problem =) Please let me know if you have any questions about this PR. |
Collaborator
|
A lot of changes in one pull request. Please split them to make it easier to review. For bigger changes an separate pull requests are preferred. Further split the changes in meaningful commits, not every editor will let you do this, but most IDE can. Then the changes can be studied per commit in a review. #529 performed a large refactoring of the code, this affects also the files you edited. Please could you apply your changes on the new code?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional modal to select which template to use when exporting a PDF file.
Add custom fonts support - please read tpl/default/README.txt for more information.
Add "_last" prefix for header and footer files to customize the header and footer of last page.
Add custom CSS selector for last PDF page.
Add @OLDREVISIONS@ selector to show page changelog. It's based on #295 and has the intention to fullfil Klap-in expectations about this feature.
Replace "strftime" deprecated PHP function by "date_format".
A template which uses the new features implemented by this PR are available at: https://github.com/eduardomozart/ScriptUtil/tree/master/Scripts/DokuWiki/dw2pdf