Fix flaky numbered-header and bookmark end-to-end tests - #550
Open
splitbrain wants to merge 1 commit into
Open
Conversation
The renderer is a singleton whose cross-page chapter counter and bookmark-level state advance in document_start(). A per-page render cache hit skips document_start(), so the numbering desyncs depending on which pages were served from cache and which were rendered fresh. Between tests this made numbered headers and bookmark levels depend on execution order and file mtimes, so the tests failed intermittently. Disable the render cache in the tests so every fixture page renders fresh.
Collaborator
|
why does it only affect the cache? |
Owner
Author
|
not sure if that is what you meant, but looking at it again I think there's a deeper issue here than just failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renderer is a singleton whose cross-page chapter counter and bookmark-level state advance in document_start(). A per-page render cache hit skips document_start(), so the numbering desyncs depending on which pages were served from cache and which were rendered fresh. Between tests this made numbered headers and bookmark levels depend on execution order and file mtimes, so the tests failed intermittently.
Disable the render cache in the tests so every fixture page renders fresh.