Skip to content

add yaml#44

Open
shalper2 wants to merge 3 commits intomainfrom
DVR-96-add-yaml
Open

add yaml#44
shalper2 wants to merge 3 commits intomainfrom
DVR-96-add-yaml

Conversation

@shalper2
Copy link
Copy Markdown
Collaborator

👉 Please ensure your pull request (PR) adheres to our Contribution Guidelines 👈

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The docs/readme.md has been reviewed and updated if needed (for bug fixes / features)
  • Provide release notes as part of the PR submission which describe high level points about the changes
  • Verify all checks are passing
  • Do NOT use the main branch of the forked repo. Create separate feature branch for raising the PR

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are adding an integration with 3rd party system
    • Please document in the docs/readme.md all methods (eg, OAuth) used to authenticate
      with the service that the add-on is integrating with

Release Notes (REQUIRED)

Added a new workflow for automated testing of ta install

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)


Thanks for contributing! ❤️

@shalper2 shalper2 requested a review from a team as a code owner March 16, 2026 14:58
Copy link
Copy Markdown
Collaborator

@edro15 edro15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shalper2 Thanks for submitting! Added some changes to make sure it works with the caller workflow and passes automation. :)

Comment on lines +4 to +5
push:
workflow_dispatch:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
push:
workflow_dispatch:
workflow_call:
inputs:
addon_name:
required: true
type: string

To enable trigger from another workflow and pass the TA name

SPLUNK_PASSWORD: password
SPLUNK_USER: admin
# Set this to your actual TA folder/app name (must match the folder name under etc/apps)
TA_NAME: TA-your_addon_name
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TA_NAME: TA-your_addon_name
TA_NAME: ${{ inputs.addon_name }}
permissions:
contents: read # to successfully checkout repo

test-ta-install:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Start Splunk (Docker)
run: |
docker run -d --name splunk \
-e SPLUNK_START_ARGS="--accept-license" \
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-e SPLUNK_START_ARGS="--accept-license" \
-e SPLUNK_START_ARGS="--answer-yes --no-prompt --accept-license" \
-e SPLUNK_GENERAL_TERMS: "--accept-sgt-current-at-splunk-com" \

This should also fix the error in the automation execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants