fix: stale task handling#122
Open
ajasnosz wants to merge 1 commit into
Open
Conversation
8 tasks
| """ | ||
| record = list(mongo_config_collection.find())[0] | ||
| if not record["currently_scheduled"] and request["schedule_new_job"]: | ||
| currently_scheduled = record["currently_scheduled"] |
Contributor
There was a problem hiding this comment.
currently_scheduled is always in the record? maybe it would be better to use .get for safety?
Contributor
Author
There was a problem hiding this comment.
It is always in the record, as we add it with init in ApplyChanges class.
| if not record["currently_scheduled"] and request["schedule_new_job"]: | ||
| currently_scheduled = record["currently_scheduled"] | ||
| if currently_scheduled and not self._is_task_still_scheduled(record.get("task_id")): | ||
| current_app.logger.info( |
Contributor
There was a problem hiding this comment.
shouldn't it be on a WARNING level? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue with stale task in celery, after resetting the scsnmp configuration, with deleted redis pvc, but kept mongodb configuration.
SC4SNMP: splunk/splunk-connect-for-snmp#1458