Skip to content

fix: change how we log resolve tester hints #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicklasl merged 1 commit into from
Apr 28, 2025
Merged

fix: change how we log resolve tester hints #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions confidence/confidence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
import base64
import dataclasses
from datetime import datetime
from enum import Enum
Expand Down Expand Up @@ -176,6 +177,19 @@ def _setup_logger(self, logger: logging.Logger) -> None:
ch.setFormatter(formatter)
logger.addHandler(ch)

def _logResolveTester(self, flag_id: str, context: Dict[str, FieldType]) -> None:
json_payload = json.dumps(
{
"flag": f"flags/{flag_id}",
"context": context,
"clientKey": self._client_secret,
}
)
base64_payload = base64.b64encode(json_payload.encode("utf-8")).decode("utf-8")
self.logger.debug(
f"Check your flag evaluation for '{flag_id}' by copy-pasting the payload to the Resolve tester: {base64_payload}" # noqa: E501
)

def _handle_evaluation_result(
self,
result: ResolveResult,
Expand All @@ -186,10 +200,7 @@ def _handle_evaluation_result(
value_path: Optional[str],
context: Dict[str, FieldType],
) -> FlagResolutionDetails[Any]:
urlEncodedJsonContext = requests.utils.quote(json.dumps(context))
self.logger.debug(
f"See resolves for '{flag_id}' in Confidence: https://app.confidence.spotify.com/flags/resolver-test?client-key={self._client_secret}&flag=flags/{flag_id}&context={urlEncodedJsonContext}" # noqa: E501
)
self._logResolveTester(flag_id, context)

if result.variant is None or len(str(result.value)) == 0:
return FlagResolutionDetails(
Expand Down
Loading