Remove deprecated SECT curves and ACME plugin#79
Open
gijzelaerr wants to merge 6 commits into
Open
Conversation
SECT curves (SECT163K1, SECT233K1, etc.) were deprecated in cryptography 46.x and removed in 48.x. We use RSA2048 exclusively. Removing them unblocks the cryptography 48.x upgrade. The ACME plugin (Let's Encrypt integration) is unused — we use DigiCert for all certificate issuance. Removing it drops ~3000 lines of code and its dependency tree (acme, josepy, DNS provider libs), reducing our maintenance surface. Cleaned up all ACME references: manage.py CLI registration, authorities/service.py ACME URL validation, dns_providers/cli.py zone lookup, and ACME_ADDITIONAL_ATTEMPTS constant.
Tests for removed functionality: SECT key generation and ACME URL allowlist validation in authority updates.
Coverage Report for CI Build 28873540323Coverage increased (+0.4%) to 60.263%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two cleanups that reduce maintenance surface and unblock dependency upgrades:
Remove deprecated SECT curves
The binary SECT curves (SECT163K1, SECT233K1, etc.) were deprecated in
cryptography46.x and removed in 48.x. We use RSA2048 exclusively. Removing them fromutils.pyandconstants.pyunblocks the cryptography 48.x upgrade (PR #74 failed on this).Remove ACME plugin
The ACME/Let's Encrypt plugin (
lemur/plugins/lemur_acme/) is unused — we use DigiCert for all certificate issuance. Removing it drops ~4900 lines and its dependency tree (acme,josepy, DNS provider integrations).Cleaned up all ACME references:
manage.py: removed CLI registrationauthorities/service.py: removed ACME URL validationdns_providers/cli.py: removed zone lookup (was ACME-only)celery.py+pending_certificates/cli.py: inlined the retry constantconstants.py: removedACME_ADDITIONAL_ATTEMPTSImpact on lemur-deploy
None — lemur-deploy doesn't use ACME or SECT curves. After merging, update the git pin in
pyproject.tomlto pick up this commit.