Fix client disconnect logged as error in WebFlux#36822
Closed
suuuuuuminnnnnn wants to merge 1 commit into
Closed
Conversation
In HttpWebHandlerAdapter.handleUnresolvedError(), when a client disconnects before the response is committed, setStatusCode(500) succeeds and logs a 500 Server Error at ERROR level. The checkAndLogClientDisconnectedException check was never reached. Move the disconnect check before the 500 status assignment. DisconnectedClientHelper already excludes remote-call wrappers so the reordering does not affect server-side error handling. Closes spring-projectsgh-36811 Signed-off-by: suuuuuuminnnnnn <sumin45402214@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
Thanks for the suggestion, but the fix is not as obvious as it seems, and also required deeper review. |
rstoyanchev
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In HttpWebHandlerAdapter.handleUnresolvedError(), when a client
disconnects before the response is committed (e.g., the client
sends a partial request body and closes the connection), the
resulting AbortedException arrives while setStatusCode(500)
still returns true. This causes the handler to immediately log
a 500 Server Error at ERROR level and return, making the
checkAndLogClientDisconnectedException branch unreachable.
This commit moves the disconnect check before the 500 status
assignment. DisconnectedClientHelper.isClientDisconnectedException
already excludes outbound/remote-call exception wrappers, so the
reordering does not affect server-side error handling.
Closes gh-36811