Allow nullable objects in authorization managers#19315
Closed
qixiangme wants to merge 1 commit into
Closed
Conversation
Several AuthorizationManager implementations and factory methods declared plain <T> type parameters. Under package-level @NullMarked, JSpecify treats a plain <T> as <T extends @nonnull Object>, so Kotlin callers could not use these implementations as AuthorizationManager<Any?> or invoke them with a null object, even though AuthorizationManager itself already declares <T extends @nullable Object>. Add <T extends @nullable Object> bounds to the implementations and factory methods that do not depend on a non-null authorization object. ObservationAuthorizationManager is intentionally left unchanged because it passes the authorization object to AuthorizationObservationContext, whose constructor requires a non-null value. Closes gh-17537 Signed-off-by: Changmin Lee <erang903@khu.ac.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several
AuthorizationManagerimplementations and factory methods declaredplain
<T>type parameters. Under package-level@NullMarked, JSpecify treatsa plain
<T>as<T extends @NonNull Object>, so Kotlin callers could not usethese implementations as
AuthorizationManager<Any?>or invoke them with anullobject, even thoughAuthorizationManageritself already declares<T extends @Nullable Object>(gh-17667).This adds
<T extends @Nullable Object>bounds to the implementations andfactory methods that do not depend on a non-null authorization object:
AuthorityAuthorizationManagerAuthenticatedAuthorizationManagerSingleResultAuthorizationManagerAllAuthoritiesAuthorizationManagerRequiredAuthoritiesAuthorizationManagerAllRequiredFactorsAuthorizationManagerConditionalAuthorizationManagerAuthorizationManagersAuthorizationManagerFactoriesOAuth2AuthorizationManagersObservationAuthorizationManageris intentionally left unchanged because itpasses the authorization object to
AuthorizationObservationContext, whoseconstructor requires a non-null value.
Closes gh-17537