Skip to content

Fix DETACH/ATTACH DATABASE, EXCHANGE TABLES, and SHOW CREATE FORMAT parsing#104

Merged
kyleconroy merged 1 commit into
mainfrom
claude/fix-sql-parsing-issues-Y2sVA
Dec 30, 2025
Merged

Fix DETACH/ATTACH DATABASE, EXCHANGE TABLES, and SHOW CREATE FORMAT parsing#104
kyleconroy merged 1 commit into
mainfrom
claude/fix-sql-parsing-issues-Y2sVA

Conversation

@kyleconroy
Copy link
Copy Markdown
Collaborator

  • Fix DETACH/ATTACH DATABASE parsing to properly handle DATABASE keyword
    instead of storing "DATABASE" literally as the table name
  • Add support for database-qualified names in EXCHANGE TABLES queries
  • Add ExchangeQuery explain output as "Rename" (matching ClickHouse)
  • Add FORMAT clause parsing for ShowQuery
  • Update ShowCreateTableQuery explain to include format identifier

This fixes parsing for ~160 test cases that were previously failing.

…arsing

- Fix DETACH/ATTACH DATABASE parsing to properly handle DATABASE keyword
  instead of storing "DATABASE" literally as the table name
- Add support for database-qualified names in EXCHANGE TABLES queries
- Add ExchangeQuery explain output as "Rename" (matching ClickHouse)
- Add FORMAT clause parsing for ShowQuery
- Update ShowCreateTableQuery explain to include format identifier

This fixes parsing for ~160 test cases that were previously failing.
@kyleconroy kyleconroy merged commit 042e803 into main Dec 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants