Add ObjectTypeArgument AST type for JSON/OBJECT type parameters#99
Merged
Conversation
This change adds support for parsing and explaining JSON and OBJECT type parameters with the ObjectTypeArgument wrapper that ClickHouse uses. Changes: - Add ObjectTypeArgument AST type to wrap expressions inside JSON/OBJECT types - Modify parser to wrap JSON/OBJECT type parameters in ObjectTypeArgument - Fix named parameter detection to not trigger when peek token is '=' (e.g., JSON(max_dynamic_paths=8) was incorrectly being parsed as a name+type pair) - Add explain output support for ObjectTypeArgument (renders as ASTObjectTypeArgument) - Update FormatDataType to unwrap ObjectTypeArgument when formatting type strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for parsing and explaining JSON and OBJECT type
parameters with the ObjectTypeArgument wrapper that ClickHouse uses.
Changes:
(e.g., JSON(max_dynamic_paths=8) was incorrectly being parsed as a name+type pair)