Skip to content

feat(table) :: add top level title - #1574

Merged
lovasoa merged 3 commits into
mainfrom
81reap/issue-1261
Oct 29, 2026
Merged

lovasoa merged 3 commits into
mainfrom
81reap/issue-1261

Conversation

@81reap

@81reap 81reap commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Now the table component accepts a top-level title, shown in a header above the table like in the list and datagrid components.

Fixes #1261

Assisted By :: Claude Opus 5.5

Now the table component accepts a top-level `title`, shown in a header above the table like in the list and datagrid components.

Fixes #1261

Assisted By :: Claude Opus 5.5
@81reap

81reap commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

on main

$ nix run .#test-sql -- table_title_1261
warning: Git tree '/home/reap/Desktop/SQLPage' is dirty

added 27 packages, and audited 29 packages in 4s

7 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> sqlpage@1.0.0 build
> node scripts/build-frontend.mjs

   Compiling sqlpage v0.47.0 (/home/reap/Desktop/SQLPage)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 4.33s
     Running tests/mod.rs (target/debug/deps/mod-7d63b6e90efdfc6a)

running 2 tests
test sql_test_files::run_database_specific_sql_test_files ... ok
test sql_test_files::run_all_sql_test_files ... FAILED

failures:

---- sql_test_files::run_all_sql_test_files stdout ----
ts=2026-10-28T21:16:20.243Z level=info msg="200 OK" target=sqlpage::access http.request.method=GET url.path=/tests/sql_test_files/component_rendering/table_title_1261.sql client.address=""

thread 'sql_test_files::run_all_sql_test_files' (2752424) panicked at tests/sql_test_files/mod.rs:287:9:
Should contain 'It works !': tests/sql_test_files/component_rendering/table_title_1261.sql
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    sql_test_files::run_all_sql_test_files

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 85 filtered out; finished in 0.38s

error: test failed, to rerun pass `--test mod`

on PR's branch

$ nix run .#test-sql -- table_title_1261
warning: Git tree '/home/reap/Desktop/SQLPage' is dirty

added 27 packages, and audited 29 packages in 4s

7 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> sqlpage@1.0.0 build
> node scripts/build-frontend.mjs

   Compiling sqlpage v0.47.0 (/home/reap/Desktop/SQLPage)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 4.44s
     Running tests/mod.rs (target/debug/deps/mod-7d63b6e90efdfc6a)

running 2 tests
test sql_test_files::run_database_specific_sql_test_files ... ok
test sql_test_files::run_all_sql_test_files ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 85 filtered out; finished in 0.37s

@81reap
81reap marked this pull request as ready for review October 28, 2026 21:32
@lovasoa
lovasoa enabled auto-merge October 29, 2026 09:14
@lovasoa
lovasoa added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit f891659 Oct 29, 2026
55 checks passed
@81reap
81reap deleted the 81reap/issue-1261 branch October 29, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add "title" as top level parameter in the table component

2 participants