Skip to content

fix(hero) :: show image first on small screens when reversed - #1582

Merged
lovasoa merged 1 commit into
mainfrom
81reap/issue/828
Oct 30, 2026
Merged

lovasoa merged 1 commit into
mainfrom
81reap/issue/828

Conversation

@81reap

@81reap 81reap commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Fixes #828

Assisted-By :: Claude Opus 5.5

@81reap

81reap commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

repro from #828

$ cat tests/end-to-end/fixtures/repro_828/index.sql 
SELECT 'hero' AS component, 'Title' AS title, 'Description' AS description, 'https://placehold.co/600x400.png' AS image, TRUE AS reverse;

$ cat tests/end-to-end/fixtures/repro_828/test.ts 
import { expect, test } from "../../fixture.ts";

test.use({ viewport: { width: 390, height: 844 } });

test("a reversed hero shows the image above the description on phones", async ({ page }) => {
  const image = await page.locator(".hero-image").boundingBox();
  const description = await page.getByText("Description").boundingBox();
  expect(image?.y).toBeLessThan(description?.y ?? 0);
});
repro_828 postgres
v0.36.0 ✘ failed
v0.47.0 ✘ failed
tree ✔ passed

On commit 62bf178: nix run .#reproduce -- repro_828 postgres v0.36.0 v0.47.0 tree

@81reap
81reap marked this pull request as ready for review October 30, 2026 00:51
@lovasoa
lovasoa added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit c5a34fc Oct 30, 2026
55 checks passed
@81reap
81reap deleted the 81reap/issue/828 branch October 30, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile layout ignores REVERSE parameter in hero component

2 participants