Repository navigation
Conversation
Now colour is properly passed through to theme Tabler's underline on the active tab. Fixes :: #791 Assisted-By :: Claude Opus 5.5
Collaborator
Author
|
reproduction from #791 $ cat tests/end-to-end/fixtures/repro_791/index.sql
SELECT 'tab' AS component;
SELECT '2023' AS title, 'red' AS color;
SELECT '2024' AS title, 'green' AS color, TRUE AS active;
SELECT '2025' AS title, 'yellow' AS color;
$ cat tests/end-to-end/fixtures/repro_791/test.ts
import { expect, test } from "../../fixture.ts";
test("only the active colored tab is underlined", async ({ page }) => {
const underlines = await page.locator(".nav-link").evaluateAll((links) => links.map((a) => getComputedStyle(a).borderBottomColor));
const transparent = "rgba(0, 0, 0, 0)";
expect(underlines.map((c) => c !== transparent)).toEqual([false, true, false]);
});
On commit 231ed30: |
81reap
marked this pull request as ready for review
October 30, 2026 01:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now colour is properly passed through to theme Tabler's underline on the active tab.
Fixes :: #791
Assisted-By :: Claude Opus 5.5