Repository navigation
fix(frontend) :: drop source map comments from joined sylesheet - #1584
Merged
Merged
Conversation
Tom Select's CSS comes with source maps that SQLPage does not care to ship. This then shows up as a 404 error in the browser. Now we remove the comments when the file is joined. Fix #1163 Assisted-By :: Claude Opus 5.5
Collaborator
Author
|
reproduction from #1163 $ cat tests/end-to-end/fixtures/repro_1163/index.sql
SELECT 'hero' AS component, 'Hero' AS title;
$ cat tests/end-to-end/fixtures/repro_1163/test.ts
import { expect, test } from "../../fixture.ts";
test("every source map an asset names exists", async ({ page }) => {
const assets = await page.evaluate(() => [...document.querySelectorAll<HTMLScriptElement | HTMLLinkElement>("script[src], link[rel=stylesheet]")].map((e) => ("src" in e ? e.src : e.href)).filter((u) => u.startsWith(location.origin)));
const missing: string[] = [];
for (const asset of assets) {
const body = await (await page.request.get(asset)).text();
const map = body.match(/sourceMappingURL=(\S+?)(\s|\*\/|$)/)?.[1];
if (map && !(await page.request.get(new URL(map, asset).href)).ok()) missing.push(new URL(map, asset).pathname);
}
expect(missing).toEqual([]);
});
On commit 41dd9db: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tom Select's CSS comes with source maps that SQLPage does not care to ship. This then shows up as a 404 error in the browser.
Now we remove the comments when the file is joined.
Fix #1163
Assisted-By :: Claude Opus 5.5