Conversation
…on golden Add unit tests for _hydrate_wire_continuations (T → | propagation in non-A columns) and dehydrate→hydrate round-trip tests through the writer/converter pipeline. Add instr-copy-multirow-2af-T golden fixture for copy instructions with a T-junction wire. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The wire continuation hydration pass blindly propagated `|` downward through every blank cell below a `T` or `|`. When the row below had a horizontal wire path from the left (e.g. a contact at C-1), the vertical wire should terminate — Click auto-snaps the horizontal path to the junction above without an explicit `|`. Skip hydration at (R+1, C) when (R+1, C-1) carries a horizontal path (anything other than blank or `|`). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…forward pass The backward scan in _find_row_topology_block could match false positive topology blocks created by flag-table tail bytes coincidentally matching the _ROW_TOPOLOGY_PREFIX. This caused spurious 30-row rungs in some SCR files (e.g. Scr12.tmp StackLight). Replace the three scanning functions (_find_row_topology_block, _find_row_topology_blocks_between, _brute_force_topology_block) with a single _find_all_row_topology_blocks that forward-scans once, skipping past each block's full extent (continuation_start). Topology blocks are then assigned to sections by position, eliminating the backward scan entirely. Also removes unused _ROW_TOPOLOGY_FLAG_ENTRY_COUNTS constant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few fixes for our hydration check
Better SCR decode