Fix/wire hydration and scr padding. Remove remove implied modifier row fallback from SCR decoder #12
Merged
Merged
Conversation
Two bugs caused CSV round-trip failures on rungs with tall AF instructions (Copy, etc.) whose continuation rows carried only vertical pass-through wires (|): 1. decode_program: The implied modifier row fallback filled horizontal wires across pure | pass-through rows, converting | to T and blanks to -. Now skips rows containing only vertical wires. 2. converter: _hydrate_wire_continuations only checked for bare "T"/"|" string tokens, missing Contact/CompareContact objects with wire_down=True. Now recognizes instruction objects that propagate wires downward. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Compares {slug}.csv against {slug}.clipboard.csv in a directory,
reporting identical/differ/missing pairs.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SCR continuation row topology blocks already encode per-row horizontal connectivity explicitly. The _implied_modifier_row_offsets heuristic was always a no-op — verified across 883 rungs in 47 SCR files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SCR continuation row topology blocks already encode per-row horizontal connectivity explicitly. The _implied_modifier_row_offsets heuristic was always a no-op — verified across 883 rungs in 47 SCR files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…om/ssweber/laddercodec into fix/wire-hydration-and-scr-padding # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.