Skip to content

Simplify encoder and consolidate CSV padding logic#9

Merged
ssweber merged 3 commits into
mainfrom
dev
Apr 8, 2026
Merged

Simplify encoder and consolidate CSV padding logic#9
ssweber merged 3 commits into
mainfrom
dev

Conversation

@ssweber

@ssweber ssweber commented Apr 8, 2026

Copy link
Copy Markdown
Owner
  • Remove AF summary block from encoder — Click accepts multi-AF rungs without it, cutting ~115 lines of complex gating
    logic
  • Consolidate tall-instruction padding into shared hydrate/dehydrate helpers in CSV converter and writer
  • Add combine_coverage.py devtool for paste smoke-testing random fixture combos
  • Simplify coverage_golden.py to regenerate all bins unconditionally

Test plan

  • All 679 tests pass
  • instr-3row-branch re-verified in Click without AF summary
  • Combined random coverage fixtures paste successfully in Click
  • make golden and make coverage-golden both clean

ssweber and others added 3 commits April 8, 2026 07:49
Writer dehydrate: replace _conditions_are_blank with _is_padding_row
that also recognizes |-only rows as strippable padding. Delete unused
_is_blank_row helper.

Converter hydrate: add _hydrate_wire_continuations pass that propagates
T/| tokens downward into blank padding cells after block finalization.
Generalize auto-pad to handle tall AF instructions at any row position,
not just row 0.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Click accepts multi-AF single-rung encodes without the summary block
appended to the last AF cell. Confirmed by paste-testing both variants.
Removes ~115 lines of complex gating logic that only one golden fixture
exercised.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add combine_coverage.py to stack random coverage CSVs into a single
multi-row rung for quick paste smoke-testing. Simplify coverage_golden.py
to regenerate all bins unconditionally instead of gating on verify log.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ssweber ssweber merged commit 95057e0 into main Apr 8, 2026
4 checks passed
@ssweber ssweber deleted the dev branch April 8, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant