refactor: rename ErrActorPanic to ActorPanicError and add Unwrap#155
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
9d4ee73 to
2b90847
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
Renames the actor-panic error type
ErrActorPanictoActorPanicErrorand gives it anUnwrap()method, bringing it in line with its sibling panic error types —GuardPanicError,AssignPanicError, andActionPanicError— which are all typed structs withError()andUnwrap(). TheErrXxxprefix is conventionally reserved for sentinel error values; this type is a struct, so the old name was misleading.Unwrap()letserrors.As/errors.Isreach an underlying error when the recovered panic value is itself an error. The type now lives alongside its siblings inerrors.go, and its field follows the siblingRecovered anyshape.Why
A consistent error surface before the 1.0 API freeze — renaming an exported type after 1.0 would be a breaking change.
Relates to: 1.0 stability hardening
Checklist
git commit -s) per the DCOtype: subject)mage checkpasses locally — thestatemodule passes lint, race tests, and govulncheck; the onlymage checkfailure is the same pre-existingtelemetry/datadogstdlib vulnerability noted above, unrelated to this change.