feat(grep): add distinguishing title to grep and glob tool blocks#22
Merged
Conversation
grep: pattern (glob) in path (e.g. "foo (*.ts) in /src") glob: pattern in dir (e.g. "**/*.ts in /src") Previously both hardcoded title:"", making multiple concurrent calls in the same turn visually identical in opencode's tool blocks. Passes args through the already-supported result(value, args) signature; no interface changes needed.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
greptool block now showspattern (include) in path(e.g.foo (*.ts) in /src)globtool block now showspattern in dir(e.g.**/*.ts in /src)title: "", making multiple concurrent calls visually identical in opencode's tool blocksChanges
Both
resultsignatures updated from(value)to(value, args)to access call args — the interface already supported this, no interface changes needed.Test Plan
stream-map.test.tsto assert new titles