fix(deps): add missing @connectrpc/connect-node for @cursor/sdk#31
Merged
Conversation
@cursor/sdk@1.0.19 imports @connectrpc/connect-node at runtime (Http2SessionManager, createNodeHttpClient, compressionGzip) but only declares @connectrpc/connect and @connectrpc/connect-web in its deps, causing ERR_MODULE_NOT_FOUND on plugin load. Add @connectrpc/connect-node@^1.6.1 to dependencies. Pinned to v1 since the SDK bundles @connectrpc/connect@1.6.1; connect-node v2.x targets the connect v2.x API. Resolves to 1.7.0.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Plugin fails to load with:
@cursor/sdk@1.0.19imports@connectrpc/connect-nodeat runtime (Http2SessionManager,createNodeHttpClient,compressionGzip) but only declares@connectrpc/connectand@connectrpc/connect-webin its dependencies — an upstream packaging bug. Node throwsERR_MODULE_NOT_FOUNDon import.Fix
Add
@connectrpc/connect-nodeas a direct dependency so the import resolves.^1.6.1(resolves to1.7.0, the highest v1).@connectrpc/connect@1.6.1, and connect-node v2.x targets the connect v2.x API. v1 is required for compatibility.Verification
npm run typecheck— cleannpm test— 181/181 passnpm run build— successimport('@cursor/sdk')resolves cleanly