fix(LineChart): guard against fewer than two points#6
Open
chinesepowered wants to merge 1 commit into
Open
Conversation
With an empty points array, coords is empty and `const [ex, ey] = coords[coords.length - 1]` destructures undefined and throws. With a single point, `i / (points.length - 1)` is 0/0 = NaN, producing NaN path geometry. Return an empty (but correctly sized) chart area when given fewer than two points, since a line needs at least two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
LineChartbreaks when given fewer than two points:points={[]}) —coordsends up empty, soconst [ex, ey] = coords[coords.length - 1]destructuresundefinedand throws, taking down the slide render.points={[42]}) —i / (points.length - 1)is0 / 0 = NaN, so the path/areadstrings and the end-dot position are allNaN.A line chart needs at least two points to be meaningful, so this guards for that case up front and renders an empty (but correctly sized,
ref-attached) chart area instead of crashing or emitting NaN geometry.Changes
src/components/Charts.tsx— early return inLineChartwhenpoints.length < 2, before any of the coordinate math.Verification
npx tsc --noEmit✓npm run build✓