Skip to content

Fix broken conditional#86

Merged
jackhodgkiss merged 1 commit into
mainfrom
fix-broken-conditional
Jun 17, 2026
Merged

Fix broken conditional#86
jackhodgkiss merged 1 commit into
mainfrom
fix-broken-conditional

Conversation

@priteau

@priteau priteau commented Jun 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@priteau priteau self-assigned this Jun 12, 2026
@priteau priteau requested a review from a team as a code owner June 12, 2026 08:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to update the SELinux check in the Ansible prerequisites task by using ansible_facts.selinux is truthy. However, the reviewer correctly points out that this does not prevent an evaluation error on the subsequent line when ansible_facts.selinux is a boolean. The reviewer suggests combining the checks into a single expression using and to leverage short-circuit evaluation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread roles/os_images/tasks/prereqs.yml Outdated
@priteau priteau force-pushed the fix-broken-conditional branch from 58a4312 to c5bdd0c Compare June 12, 2026 08:43
@priteau priteau requested a review from jovial June 12, 2026 12:11
@jackhodgkiss jackhodgkiss merged commit a6dbe07 into main Jun 17, 2026
4 checks passed
@jackhodgkiss jackhodgkiss deleted the fix-broken-conditional branch June 17, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants