Synchronise 2025.1 with upstream#15
Merged
Merged
Conversation
A vulnerability in RFB reason text processing was discovered. If the attacker controls host VNC server, they can send a reason length up to 4 GB to the security proxy causing it to crash. The proxy is shared between all tenants, so crashing it will deny console access for everyone. Cap the reason length at 256 bytes and if the reason is larger than that, the reason is not read and a reasonable and coherent error message is returned. Closes-Bug: 2155052 Co-Authored-By: Nuutti Hakala <nuutti.hakala@est.tech> Generated-By: Claude Opus 4.6 Change-Id: If2bc6f66f4ef5eb4f0a99c8664d81e11664bc641 Signed-off-by: Nuutti Hakala <nuutti.hakala@est.tech> Signed-off-by: Saad Zia <saad.zia@est.tech> (cherry picked from commit 9babeeb)
github-actions
Bot
added
automated
priteau
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2025.1 from upstream stable/2025.1.