prometheus: Fix Grafana blackbox endpoint checks#887
Open
claudia-lola wants to merge 1 commit into
Open
Conversation
Split the Grafana blackbox endpoint into separate public and internal checks. The public endpoint is now only monitored when both Grafana and ``enable_grafana_external`` are enabled (which is the default when enabling Grafana), matching the HAProxy external listener check. The internal endpoint remains monitored when Grafana is enabled and either external Grafana is disabled or the internal and external VIPs are separate. This avoids losing Grafana monitoring when ``enable_grafana_external`` is disabled. Closes-Bug: #2157003 Change-Id: Iea3b21dcfa4284f2a74c1bee95577ce8a219cf5f Signed-off-by: Dawud <dawud@stackhpc.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes Prometheus blackbox exporter monitoring for Grafana by separating checks for the public (external) and internal Grafana endpoints, ensuring monitoring aligns with whether external Grafana access is actually enabled.
Changes:
- Gate the public Grafana blackbox check on both
enable_grafanaandenable_grafana_external. - Add a separate internal Grafana blackbox check that remains enabled when external Grafana is disabled or when internal/external VIPs differ.
- Add a release note documenting the corrected behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| releasenotes/notes/fix-grafana-external-blackbox-check-c1b97a2406ad3b15.yaml | Documents the monitoring behavior change for Grafana blackbox checks. |
| ansible/roles/prometheus/defaults/main.yml | Splits Grafana blackbox endpoints into separate public/internal checks with corrected enablement conditions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the Grafana blackbox endpoint into separate public and internal checks. The public endpoint is now only monitored when both Grafana and
enable_grafana_externalare enabled (which is the default when enabling Grafana), matching the HAProxy external listener check.The internal endpoint remains monitored when Grafana is enabled and either external Grafana is disabled or the internal and external VIPs are separate. This avoids losing Grafana monitoring when
enable_grafana_externalis disabled.Closes-Bug: #2157003
Change-Id: Iea3b21dcfa4284f2a74c1bee95577ce8a219cf5f