fix: octavia-api broken in multinode OVS

[elelaysh]

When kolla_enable_ovn is false, fallback to amphora driver

[gemini-code-assist]

Code Review

This pull request correctly makes the octavia_provider_drivers conditional based on whether OVN is enabled, which is a good fix for non-OVN deployments. However, the change is incomplete as it does not update the related octavia_provider_agents configuration. This will likely cause issues when OVN is disabled. I have added a comment to highlight this and suggest a fix to ensure the Octavia configuration remains consistent.

[elelaysh]

I don't know a correct value for the agent for amphora.

[Alex-Welsh]

I don't know a correct value for the agent for amphora.

https://github.com/openstack/kolla-ansible/blob/496dd763d82eaa666549556c28f1f4fb74a8d446/ansible/roles/octavia/defaults/main.yml#L390

My general strategy with things like that is to just grep through the source of kolla ansible/kayobe etc for the variable to see if I can find it defined anywhere already

[elelaysh]

I don't know a correct value for the agent for amphora.

https://github.com/openstack/kolla-ansible/blob/496dd763d82eaa666549556c28f1f4fb74a8d446/ansible/roles/octavia/defaults/main.yml#L390

My general strategy with things like that is to just grep through the source of kolla ansible/kayobe etc for the variable to see if I can find it defined anywhere already

Thank you Alex, you are right: I should have grepped. I've corrected with amphora_agent

[Alex-Welsh]

@elelaysh does amphora actually work in a multinode? has it been tested?

[elelaysh]

Needs additional fixes:

• feat: add steps for deploying amphora terraform-kayobe-multinode#86
• feat: add amphora load balancers to ci-multinode #1517

[elelaysh]

This doc in #1362 might help

[Alex-Welsh]

@elelaysh I don't think we'll have time to come back to this soon. Could you close this PR, and maybe instead add a link to your branch in the Jira ticket?

[elelaysh]

ok, let's close. Thanks