Skip to content

Use StackHPC Ironic fork#2340

Merged
bbezak merged 1 commit into
stackhpc/2025.1from
shpc-ironic-fork
Jun 3, 2026
Merged

Use StackHPC Ironic fork#2340
bbezak merged 1 commit into
stackhpc/2025.1from
shpc-ironic-fork

Conversation

@bbezak

@bbezak bbezak commented Jun 2, 2026

Copy link
Copy Markdown
Member

Use the StackHPC Ironic fork to include diskless boot support and architecture-specific virtual media ESP bootloader selection.

The required changes are provided by:
[1] stackhpc/ironic#4
[2] stackhpc/ironic#9

@bbezak bbezak requested a review from a team as a code owner June 2, 2026 07:19
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Jun 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures Kayobe to use the StackHPC Ironic fork by adding the ironic-base source repository and updating the Kolla image tags for Ironic, including a new tag for Rocky 10. A release note is also added to document the diskless boot and ESP bootloader selection features. However, a review comment points out that adding rocky-10 to ironic without also defining corresponding tags for ironic_dnsmasq and ironic_neutron_agent will lead to deployment failures on Rocky 10 systems.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread etc/kayobe/kolla-image-tags.yml Outdated
@bbezak bbezak marked this pull request as draft June 2, 2026 07:29
@bbezak bbezak force-pushed the shpc-ironic-fork branch from fe1b922 to 456daf5 Compare June 2, 2026 09:06
@Alex-Welsh

Copy link
Copy Markdown
Member

@seunghun1ee I know you had some issues building Ironic images recently. Does this look alright to you?

dougszumski
dougszumski previously approved these changes Jun 3, 2026
Comment thread etc/kayobe/kolla-image-tags.yml Outdated
Use the StackHPC Ironic fork to include diskless boot support and
architecture-specific virtual media ESP bootloader selection.

The required changes are provided by:
[1] stackhpc/ironic#4
[2] stackhpc/ironic#9

Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
@seunghun1ee

Copy link
Copy Markdown
Member

@seunghun1ee I know you had some issues building Ironic images recently. Does this look alright to you?

Discussed in the office. This was not relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants