Skip to content

Implement multinode testing for Rocky 10#2377

Open
owenjones wants to merge 1 commit into
stackhpc/2025.1from
rl10/multinode
Open

Implement multinode testing for Rocky 10#2377
owenjones wants to merge 1 commit into
stackhpc/2025.1from
rl10/multinode

Conversation

@owenjones

Copy link
Copy Markdown
Member
  • Multinode workflows modified to add Rocky 10 as an option
  • ci-multinode environment updated to support multinode testing with Rocky 10
  • cephadm deployment now supported in Rocky 10; The cephadm collection has been bumped to 1.22.1 which updates the Ceph repository URL for Squid on Rocky 10. The Rocky crypto policy in use during Ceph deployment is required to be downgraded to LEGACY in order to use Ceph's release signing key. The policy is reverted after deployment or on deployment failure

@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Jun 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Rocky 10 in the ci-multinode environment, including bumping the stackhpc.cephadm collection to version 1.22.1 and adding logic to temporarily downgrade the crypto policy to LEGACY on Rocky 10 during Ceph deployment. It also updates package repository versions for Rocky 10, CentOS Stream 10, and RHEL 10, and configures Valkey/Redis based on the OS version. Feedback on these changes highlights a potential templating error on non-Rocky 10 hosts where the skipped crypto_policy variable lacks a stdout attribute, which can be resolved using the default filter. Additionally, it is recommended to add changed_when: false to the read-only crypto policy discovery task to maintain proper idempotency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread etc/kayobe/ansible/ceph/cephadm-deploy.yml Outdated
Comment thread etc/kayobe/ansible/ceph/cephadm-deploy.yml
@owenjones owenjones marked this pull request as ready for review June 18, 2026 15:28
Comment thread .github/workflows/stackhpc-multinode.yml
Comment thread etc/kayobe/environments/ci-multinode/stackhpc-ci.yml Outdated
* Multinode workflows modified to add Rocky 10 as an option
* `ci-multinode` environment updated to support multinode testing with
  Rocky 10
* cephadm deployment now supported in Rocky 10; The cephadm collection
  has been bumped to 1.22.1 which updates the Ceph repository URL for
  Squid on Rocky 10. The Rocky crypto policy in use during Ceph
  deployment is required to be downgraded to LEGACY in order to use
  Ceph's release signing key. The policy is reverted after deployment
  or on deployment failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants