Skip to content

Stop running GHA tox jobs in stackhpc/nova@2026.1#540

Merged
priteau merged 1 commit into
mainfrom
nova_no_gha
Jun 19, 2026
Merged

Stop running GHA tox jobs in stackhpc/nova@2026.1#540
priteau merged 1 commit into
mainfrom
nova_no_gha

Conversation

@mnasiadka

@mnasiadka mnasiadka commented Jun 17, 2026

Copy link
Copy Markdown
Member

No description provided.

@mnasiadka mnasiadka requested a review from a team as a code owner June 17, 2026 21:11
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 17, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for per-release ignored workflows in the source repository synchronization process, specifically ignoring the tox workflow for the 2026.1 release. It also updates the Terraform configuration for the nova repository. The reviewer suggested using default({}, true) instead of default({}) for per_release_ignored_workflows in main.yml to prevent potential TypeError issues if the value is explicitly defined as null.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ansible/roles/source-repo-sync/tasks/main.yml Outdated
@stackhpc-ci

stackhpc-ci commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output 

Success! The configuration is valid.

Terraform Plan 📖success

Show Plan 

undefined

Pusher: @mnasiadka, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@priteau

priteau commented Jun 18, 2026

Copy link
Copy Markdown
Member

What is the reason?

@mnasiadka

mnasiadka commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

What is the reason?

Because we run the same jobs using Zuul

@priteau priteau merged commit b6e6dc4 into main Jun 19, 2026
5 checks passed
@priteau priteau deleted the nova_no_gha branch June 19, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@priteau priteau priteau approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnasiadka @stackhpc-ci @priteau