feat: add support for RGW#115
Open
jackhodgkiss wants to merge 1 commit into
Open
Conversation
In order for `RGW` to be deployed the RGW group needs to include the storage hosts as locations for `RGW` daemons to be deployed. Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the templates/hosts.tpl template to populate the [rgws] group by iterating over storage_hostname. The reviewer suggests renaming the singular variable storage_hostname to a plural form (such as storage_hostnames or storage_hosts) to clearly indicate that it represents a collection, which improves readability and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for
RGWto be deployed the RGW group needs to include the storage hosts as locations forRGWdaemons to be deployed.