Skip to content

fix(status): print SSE log timestamps with correct integer width #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stackia merged 1 commit into from
Jun 12, 2026
+6 −5
Merged

fix(status): print SSE log timestamps with correct integer width #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/status.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,11 +672,12 @@
char escaped[STATUS_LOG_ENTRY_LEN * 2];
json_escape_string(status_shared->log_entries[log_idx].message, escaped, sizeof(escaped));

len += snprintf(buffer + len, buffer_capacity - (size_t)len,
"{\"timestamp\":%ld,\"level\":%d,\"levelName\":\"%s\",\"message\":\"%"
"s\"}",
(long)status_shared->log_entries[log_idx].timestamp, status_shared->log_entries[log_idx].level,
status_get_log_level_name(status_shared->log_entries[log_idx].level), escaped);
len +=
snprintf(buffer + len, buffer_capacity - (size_t)len,

Check failure

Code scanning / CodeQL

Potentially overflowing call to snprintf High

The
size argument
Loading
of this snprintf call is derived from its return value, which may exceed the size of the buffer and overflow.
"{\"timestamp\":%lld,\"level\":%d,\"levelName\":\"%s\",\"message\":\"%"
"s\"}",
(long long)status_shared->log_entries[log_idx].timestamp, status_shared->log_entries[log_idx].level,
status_get_log_level_name(status_shared->log_entries[log_idx].level), escaped);
}
last_write_index = cur_wi;
last_log_count = cur_count;
Expand Down
Loading