STACKITLB-1837 | add ALB certificates to provider by david-mey-STACKIT · Pull Request #1296 · stackitcloud/terraform-provider-stackit

david-mey-STACKIT · 2026-03-13T17:20:50Z

Description

Add ALB TLS certificates provider (API: https://docs.api.stackit.cloud/documentation/certificates/version/v2)

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see examples/ directory)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Acceptance tests got implemented or updated (see e.g. here)
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>

github-actions · 2026-03-28T03:53:28Z

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

docs/resources/application_load_balancer.md

stackit/internal/services/albcertificates/certificate/datasource.go

stackit/internal/services/albcertificates/certificate/resource.go

stackit/internal/services/albcertificates/certificate_acc_test.go

marceljk · 2026-03-31T13:08:38Z

stackit/internal/services/albcertificates/certificate_acc_test.go

+					resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "public_key"),
+					resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "private_key"),


you can do here the same check mentioned above

Pair check for private key and tls_private_key.test.private_key_pem is missing

stackit/internal/services/albcertificates/utils/util.go

marceljk · 2026-03-31T13:12:02Z

stackit/internal/testutil/testutil.go

+	}
+	return fmt.Sprintf(`
+		provider "stackit" {
+			cart_custom_endpoint = "%s"


Suggested change

cart_custom_endpoint = "%s"

alb_certificates_custom_endpoint = "%s"

marceljk · 2026-03-31T13:13:13Z

stackit/internal/services/albcertificates/utils/util.go

+	if providerData.ALBCustomEndpoint != "" {
+		apiClientConfigOptions = append(apiClientConfigOptions, config.WithEndpoint(providerData.ALBCustomEndpoint))
+	}


Suggested change

if providerData.ALBCustomEndpoint != "" {

apiClientConfigOptions = append(apiClientConfigOptions, config.WithEndpoint(providerData.ALBCustomEndpoint))

}

if providerData.ALBCertificatesCustomEndpoint != "" {

apiClientConfigOptions = append(apiClientConfigOptions, config.WithEndpoint(providerData.ALBCertificatesCustomEndpoint))

}

marceljk · 2026-04-02T07:42:55Z

stackit/internal/testutil/testutil.go

 	CdnCustomEndpoint             = customEndpointConfig{envVarName: "TF_ACC_CDN_CUSTOM_ENDPOINT", providerName: "cdn_custom_endpoint"}
+	CertCustomEndpoint            = customEndpointConfig{envVarName: "TF_ACC_CERT_CUSTOM_ENDPOINT", providerName: "alb_certificates_custom_endpoint"}


Please keep the prefix ALB, because when a new service will be onboard which is also for certifcates, it can become a conflict

Suggested change

CdnCustomEndpoint = customEndpointConfig{envVarName: "TF_ACC_CDN_CUSTOM_ENDPOINT", providerName: "cdn_custom_endpoint"}

CertCustomEndpoint = customEndpointConfig{envVarName: "TF_ACC_CERT_CUSTOM_ENDPOINT", providerName: "alb_certificates_custom_endpoint"}

ALBCertCustomEndpoint = customEndpointConfig{envVarName: "TF_ACC_ALB_CERT_CUSTOM_ENDPOINT", providerName: "alb_certificates_custom_endpoint"}

CdnCustomEndpoint = customEndpointConfig{envVarName: "TF_ACC_CDN_CUSTOM_ENDPOINT", providerName: "cdn_custom_endpoint"}

marceljk · 2026-04-02T07:43:23Z

stackit/internal/services/albcertificates/testfiles/resource-min.tf

+
+  subject {
+    common_name  = "localhost"
+    organization = "Stackit Test"


Suggested change

organization = "Stackit Test"

organization = "STACKIT Test"

marceljk · 2026-04-02T07:43:33Z

stackit/internal/services/albcertificates/testfiles/resource-max.tf

+
+  subject {
+    common_name  = "localhost"
+    organization = "Stackit Test"


Suggested change

organization = "Stackit Test"

organization = "STACKIT Test"

marceljk · 2026-04-02T07:44:37Z

stackit/internal/services/albcertificates/certificate_acc_test.go

+	for _, rs := range s.RootModule().Resources {
+		if rs.Type != "stackit_loadbalancer" {
+			continue
+		}
+		// cetificate terraform ID: = "[project_id],[region],[name]"
+		certificateName := strings.Split(rs.Primary.ID, core.Separator)[1]
+		certificateToDestroy = append(certificateToDestroy, certificateName)


wrong check for resource type and wrong terraform ID structure

marceljk · 2026-04-02T07:45:28Z

stackit/internal/services/albcertificates/certificate_acc_test.go

+					resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "public_key"),
+					resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "private_key"),


Pair check for private key and tls_private_key.test.private_key_pem is missing

marceljk · 2026-04-02T07:45:36Z

stackit/internal/services/albcertificates/certificate_acc_test.go

+					resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "public_key"),
+					resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "private_key"),


Pair check for private key and tls_private_key.test.private_key_pem is missing

marceljk · 2026-04-02T07:47:45Z

stackit/internal/services/albcertificates/certificate/datasource.go

+func (r *certDataSource) Schema(_ context.Context, _ datasource.SchemaRequest, resp *datasource.SchemaResponse) {
+	descriptions := map[string]string{
+		"main":        "Certificates resource schema.",
+		"id":          "Terraform's internal resource ID. It is structured as `project_id`,`region`,`cert_id`.",


Suggested change

"id": "Terraform's internal resource ID. It is structured as `project_id`,`region`,`cert_id`.",

"id": "Terraform's internal resource ID. It is structured as \"`project_id`,`region`,`cert_id`\".",

marceljk · 2026-04-02T07:48:07Z

stackit/internal/services/albcertificates/certificate/resource.go

+func (r *certificatesResource) Schema(_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) {
+	descriptions := map[string]string{
+		"main":        "Certificates resource schema.",
+		"id":          "Terraform's internal resource ID. It is structured as `project_id`,`region`,`cert_id`.",


Suggested change

"id": "Terraform's internal resource ID. It is structured as `project_id`,`region`,`cert_id`.",

"id": "Terraform's internal resource ID. It is structured as \"`project_id`,`region`,`cert_id`\".",

marceljk · 2026-04-02T07:48:33Z

examples/resources/stackit_alb_certificate/resource.tf

+
+  subject {
+    common_name  = "localhost"
+    organization = "Stackit Test"


Suggested change

organization = "Stackit Test"

organization = "STACKIT Test"

marceljk · 2026-04-02T07:58:56Z

stackit/internal/services/albcertificates/certificate_acc_test.go

+	ctx := context.Background()
+	var client *certSdk.APIClient
+	var err error
+	if testutil.ALBCustomEndpoint == "" {


wrong custom endpoint

marceljk · 2026-04-02T07:59:59Z

stackit/internal/services/albcertificates/certificate_acc_test.go

+			// Creation
+			{
+				ConfigVariables: testConfigVarsMin,
+				Config:          testutil.CertProviderConfig() + resourceMinConfig,


the acc tests must be updated because of the latest changes where the config builder what introduced

david-mey-STACKIT and others added 12 commits February 5, 2026 17:25

STACKITLB-798 | add ALB TF provider

0cac777

apply PR suggestions: stackitcloud#1198

ac05133

Merge remote-tracking branch 'upstream/main'

0f6a8b4

apply PR suggestions

7dd76db

Merge remote-tracking branch 'upstream/main'

d6f8b0d

apply PR suggestions

3e4c3db

Update stackit/internal/services/alb/applicationloadbalancer/resource.go

363e809

Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>

apply PR suggestions

b7bf33e

Merge remote-tracking branch 'upstream/main'

d69fb92

Merge branch 'main' into main

060b50d

STACKITLB-1837 | add ALB tls certificates provider

7fd2b9f

Merge remote-tracking branch 'upstream/main'

7beb13e

david-mey-STACKIT force-pushed the main branch 4 times, most recently from 289b525 to f74a895 Compare March 16, 2026 14:10

Merge remote-tracking branch 'upstream/main'

f3994d9

david-mey-STACKIT force-pushed the main branch from f74a895 to f3994d9 Compare March 16, 2026 14:13

david-mey-STACKIT marked this pull request as ready for review March 16, 2026 14:15

david-mey-STACKIT requested a review from a team as a code owner March 16, 2026 14:15

github-actions bot added the Stale PR is marked as stale due to inactivity. label Mar 28, 2026

marceljk reviewed Mar 31, 2026

View reviewed changes

marceljk removed the Stale PR is marked as stale due to inactivity. label Mar 31, 2026

david-mey-STACKIT added 4 commits April 1, 2026 09:33

apply PR suggestions

3032f2d

Merge remote-tracking branch 'upstream/main'

da41bda

apply PR suggestions

83e7536

Merge remote-tracking branch 'upstream/main'

693ee08

marceljk reviewed Apr 2, 2026

View reviewed changes

		resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "public_key"),
		resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "private_key"),

	cart_custom_endpoint = "%s"
	alb_certificates_custom_endpoint = "%s"

		CdnCustomEndpoint = customEndpointConfig{envVarName: "TF_ACC_CDN_CUSTOM_ENDPOINT", providerName: "cdn_custom_endpoint"}
		CertCustomEndpoint = customEndpointConfig{envVarName: "TF_ACC_CERT_CUSTOM_ENDPOINT", providerName: "alb_certificates_custom_endpoint"}

	"id": "Terraform's internal resource ID. It is structured as `project_id`,`region`,`cert_id`.",
	"id": "Terraform's internal resource ID. It is structured as \"`project_id`,`region`,`cert_id`\".",

Conversation

david-mey-STACKIT commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

david-mey-STACKIT commented Mar 13, 2026 •

edited

Loading