ROX-35079: drop Application from the central chart#21585
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
📝 WalkthroughWalkthroughThis PR removes the Helm render ChangesRemove Application Resource and APIVersions Override
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🚀 Build Images ReadyImages are ready for commit a6d4e2a. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-406-ga6d4e2a609 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21585 +/- ##
==========================================
- Coverage 50.37% 50.33% -0.04%
==========================================
Files 2844 2844
Lines 218473 218470 -3
==========================================
- Hits 110058 109976 -82
- Misses 100432 100494 +62
- Partials 7983 8000 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/retest |
|
@porridge: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
08b3836 to
a6d4e2a
Compare
|
Actually this needs to wait until after we deprecate this. Closing (at least for now). |
Description
This API is effectively abandoned, and the only OpenShift ecosystem consumer - RH ACM - has deprecated functionality related to this API in 2025 and is likely to stop shipping the app.k8s.io CRD soon.
Applicationresource, targeted for the next releaseUser-facing documentation
Testing and quality
Automated testing
How I validated my change
N/A