Skip to content

ROX-35079: drop Application from the central chart#21585

Closed
porridge wants to merge 1 commit into
masterfrom
porridge/ROX-35079-drop
Closed

ROX-35079: drop Application from the central chart#21585
porridge wants to merge 1 commit into
masterfrom
porridge/ROX-35079-drop

Conversation

@porridge

@porridge porridge commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

This API is effectively abandoned, and the only OpenShift ecosystem consumer - RH ACM - has deprecated functionality related to this API in 2025 and is likely to stop shipping the app.k8s.io CRD soon.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • not modified existing tests, this is apparently untested functionality being removed

How I validated my change

N/A

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@porridge

porridge commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes the Helm render APIVersions override path and updates test suites to stop injecting app.k8s.io/v1beta1/Application into Helm capabilities. The central chart’s Application template is also removed.

Changes

Remove Application Resource and APIVersions Override

Layer / File(s) Summary
Remove APIVersions field and rendering logic
pkg/helm/util/render.go
Removes the APIVersions field from Options and the logic in Render that copied it into chartutil.Capabilities; capabilities now use the default version set.
Remove APIVersions overrides from test suites
pkg/helm/charts/tests/centralservices/base_suite_test.go, pkg/helm/charts/tests/securedclusterservices/base_suite_test.go, pkg/helm/config/roundtrip_test.go
Removes ReleaseOptions.APIVersions overrides from three Helm test setups.
Remove Application Helm template
image/templates/helm/stackrox-central/templates/00-stackrox-application.yaml
Removes the central chart template that rendered the app.k8s.io/v1beta1 Application resource.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: removing the Application resource from the central chart.
Description check ✅ Passed The PR description covers the change, docs, testing, and validation sections, with only CI inspection left unchecked.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch porridge/ROX-35079-drop

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit a6d4e2a. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-406-ga6d4e2a609

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.33%. Comparing base (f5fa85c) to head (08b3836).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21585      +/-   ##
==========================================
- Coverage   50.37%   50.33%   -0.04%     
==========================================
  Files        2844     2844              
  Lines      218473   218470       -3     
==========================================
- Hits       110058   109976      -82     
- Misses     100432   100494      +62     
- Partials     7983     8000      +17     
Flag Coverage Δ
go-unit-tests 50.33% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@porridge

porridge commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown

@porridge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-21-qa-e2e-tests 08b3836 link false /test ocp-4-21-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@porridge porridge force-pushed the porridge/ROX-35079-drop branch from 08b3836 to a6d4e2a Compare July 7, 2026 10:07
@porridge porridge marked this pull request as ready for review July 7, 2026 10:11
@porridge porridge requested a review from a team as a code owner July 7, 2026 10:11
@porridge porridge requested review from mclasmeier and removed request for a team July 7, 2026 10:11
@porridge porridge added the auto-retest PRs with this label will be automatically retested if prow checks fails label Jul 7, 2026
@porridge

porridge commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Actually this needs to wait until after we deprecate this. Closing (at least for now).

@porridge porridge closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant