feat(backup)!: add support for new velero fields

[Copilot]

Summary

• Add new Velero backup fields: defaultVolumesToFsBackup, snapshotMoveData, csiSnapshotTimeout, datamover, itemOperationTimeout, volumeSnapshotLocations, includedNamespaceScopedResources, excludedNamespaceScopedResources, and orderedResources
• Deprecate defaultVolumesToRestic in favor of defaultVolumesToFsBackup with backward compatibility
• Add API version capability guard (velero.io/v1) to skip rendering when CRD is not available
• Use selectorLabels for labelSelector.matchLabels instead of hardcoded part-of
• Make all optional fields conditionally rendered (only included when explicitly set)
• Normalize template indentation to use nindent consistently

Breaking changes

• defaultVolumesToRestic is now deprecated (still functional). Users should migrate to defaultVolumesToFsBackup.
• The Backup resource is no longer rendered if the velero.io/v1 API is not available in the cluster.

Test plan

• Unit tests cover all new fields (presence and absence)
• Unit tests verify deprecated defaultVolumesToRestic backward compatibility
• Unit tests verify selector labels
• All 371 tests pass

[aslafy-z]

@copilot I opened the network flows.

• Check for additional fields.
• Infer the field description from the CRD field descriptions.

[Copilot]

@copilot I opened the network flows.

• Check for additional fields.
• Infer the field description from the CRD field descriptions.

I've completed a comprehensive review of the Velero CRDs and added all major missing backup fields. Here's what was added:

Additional fields from Velero CRD:

• labelSelector - Custom resource filtering (with smart fallback to default)
• includeClusterResources - Control cluster resource inclusion
• csiSnapshotTimeout, datamover, itemOperationTimeout - Various timeout and configuration options
• volumeSnapshotLocations - Volume snapshot location configuration
• excludedNamespaces - Namespace exclusion support
• Resource scope controls: includedClusterScopedResources, excludedClusterScopedResources, includedNamespaceScopedResources, excludedNamespaceScopedResources
• orderedResources - Resource backup ordering

Improved documentation:
All field descriptions were enhanced using the official Velero CRD documentation, providing clear guidance on usage and expected values.

Testing:
Added 14 new tests covering all field scenarios. All 232 tests pass including comprehensive validation of conditional rendering.

Commit: 87fd82b

[aslafy-z]

@copilot

• remove update to the labelSelector field.
• add missing & updated fields to readme.
• if there is some int values, make sure you use "if not type invalid .Value.value" instead of "if .Value.value"

[Copilot]

@copilot

• remove update to the labelSelector field.
  ...

All feedback addressed in commit cfc6008:

• Removed labelSelector field updates from backup.yaml (reverted to original)
• Added all missing backup fields to README documentation with proper descriptions
• Fixed boolean field validation to use kindIs "invalid" instead of simple if checks for includeClusterResources and snapshotMoveData

The backup template now maintains backward compatibility while properly handling null boolean values.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/helm-unittest/helm-unittest/releases/latest
  • Triggering command: curl -sL REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[aslafy-z]

@copilot

• Remove these fields: includeClusterResources, excludedNamespaces, includedClusterScopedResources, excludedClusterScopedResources

• Fix includedNamespaces so multiple namespaces can be specified without issue.

[aslafy-z]

@copilot remove the .gitignore change

[Copilot]

@copilot

• Remove these fields: includeClusterResources, excludedNamespaces, includedClusterScopedResources, excludedClusterScopedResources
  ...

Completed the requested changes in commit 0d201a9:

• Removed fields: includeClusterResources, excludedNamespaces, includedClusterScopedResources, excludedClusterScopedResources from backup template, values.yaml, and README documentation

• Fixed includedNamespaces: Now properly supports multiple namespaces without YAML structure issues. The field is correctly rendered as a single array instead of repeating the key for each namespace.

Template now correctly generates:

includedNamespaces:
- namespace1
- namespace2
- namespace3

Instead of the problematic structure that would repeat the key.

[Copilot]

@copilot remove the .gitignore change

Removed the .gitignore change in commit 4d02ee8. The helm-unittest.tar.gz entry has been removed from .gitignore.

[aslafy-z]

@copilot
I opened network flows, fix the tests.

[Copilot]

@copilot
I opened network flows, fix the tests.

Fixed the tests in commit d266b19. Removed tests for fields that were previously removed (includeClusterResources, excludedNamespaces, includedClusterScopedResources, excludedClusterScopedResources) and updated the labelSelector test to match the current implementation using application.selectorLabels. All 226 tests now pass.

[aslafy-z]

@copilot Analyze PR content and update the PR description to reflect the real changes.

[Copilot]

@copilot Analyze PR content and update the PR description to reflect the real changes.

Updated the PR description to accurately reflect the actual changes implemented. The key updates focus on:

1. Critical bug fix: Fixed includedNamespaces YAML structure to properly support multiple namespaces
2. Deprecated field replacement: Changed defaultVolumesToRestic to defaultVolumesToFsBackup
3. Essential field additions: Added csiSnapshotTimeout, datamover, itemOperationTimeout, volumeSnapshotLocations, snapshotMoveData, namespace-scoped resource controls, and orderedResources
4. Template improvements: Updated labelSelector usage and added null-safe boolean handling
5. Documentation enhancements: Comprehensive README updates and inline documentation

The description now provides clear before/after examples showing the critical namespace bug fix and demonstrates proper usage of the new fields.

[rasheedamir]

@aslafy-z looks good to me but I will definitely suggest to do some integration testing and validate it works as expected b4 merging

[rasheedamir]

@d3adb5 can you please review this as well?

[d3adb5]

Support for defaultVolumesToRestic is being dropped entirely despite its mention in the values file and the values table in the README.md.

Additionally, I think the Helm templating should be indented to match the indentation level of the fields they are manipulating, as shown in one of the threads I opened. Without that, the eyes have to dart to the left more than I'd like. Plus, the nindent function kind of exists to allow us to indent our template expansions.

[aslafy-z]

@copilot resolve the merge conflicts in this pull request

[rasheedamir]

@d3adb5 can you please review it again?

[d3adb5]

Leaving an approval since I'm okay with it the way it is, but I did leave a couple comments. 🙇

[d3adb5]

Small suggestion: since .Values.backup is dedicated to Velero, shouldn't the absence of the velero.io/v1 API group throw an error?

Suggested change

	{{- if and .Values.backup .Values.backup.enabled (.Capabilities.APIVersions.Has "velero.io/v1") -}}
	{{- if and .Values.backup .Values.backup.enabled }}
	{{- if not (.Capabilities.APIVersions.Has "velero.io/v1") }}
	{{- fail "velero.io/v1 not found on the target cluster, set backup.enabled to false" }}
	{{- end }}

[d3adb5]

Typo of mine, my bad.

Suggested change

	- it: uses restic integration is explicitly enabled
	- it: uses restic integration if explicitly enabled