feat(schema): use comma-separated helm-docs type hints#539
Draft
aslafy-z wants to merge 2 commits into
Draft
Conversation
Replace jq post-processing with native multi-type annotations in values.yaml. Optional fields now declare nullability inline, and IntOrString/multi-type fields use comma-separated hints. Depends on: dadav/helm-schema#219 Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jqpost-processing ingen-helm-schemawith native comma-separated type hints invalues.yaml(string, null),(object, null))(int, string, null), extraObjects uses(list, object, null)jqtool dependency frommise.tomlDependencies
Requires rebase on dadav/helm-schema#219 which adds
nullas a supported helm-docs type in helm-schema.Test plan
mise run gen-schemaand verify no warnings aboutnulltypevalues.schema.jsonagainst previous outputmise run lintandmise run test