Skip to content

added invariant check for null data values#4

Open
wmyers wants to merge 1 commit intomasterfrom
add-missing-data-logging
Open

added invariant check for null data values#4
wmyers wants to merge 1 commit intomasterfrom
add-missing-data-logging

Conversation

@wmyers
Copy link
Copy Markdown

@wmyers wmyers commented Sep 18, 2017

Why is this change necessary?

  • If a falsy data prop is passed in to a Radar component then a deep React rendering error occurs.

How does it address the issue?

  • Adding invariant (for meaningful errors in non-PRODUCTION envs) to log if data is passed with a falsy value.

What side effects does this change have?

  • None

How was it tested?

  • Should pass test suite

@wmyers wmyers self-assigned this Sep 18, 2017
@wmyers wmyers requested a review from adamjcsmith September 18, 2017 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant