[6.x] Remove mb-1.5 when no visible content in a Label#14710
Open
martyf wants to merge 2 commits into
Open
Conversation
Contributor
|
@martyf Hey Marty, cheers for the PR. I checked this branch out but I still see a margin of
Let me know if I'm missing something! – here's my blueprint |
Contributor
Author
|
That's a different issue - see #14707 That is one I tried to fix up, but is deeper than just changing one file (I believe). The |
Fields with "Hide Display" enabled were still leaving a gap below the label in the publish form, even though the label is only shown to screen readers. Spacing is now skipped when the display label is hidden. Also fixes label spacing when the label is passed in via a slot rather than the text prop.
Contributor
|
I just pushed to your branch. I think this fixes everything, but I'll let @jasonvarga review 😄 Jason, you can test this out with hidden labels, here's a quick blueprint demo: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When a Field is configured to not show the Display Label, the
mb-1.5is still applied.This PR only applies the
mb-1.5when the label has visible content.This is related to #14707, and requires that be resolved to be notice.