Some slight modifications to factorialize_init_state#246
Merged
Conversation
Sahel13
approved these changes
Jun 2, 2026
Co-authored-by: Sahel Iqbal <sahel13miqbal@proton.me>
SamDuffield
added a commit
that referenced
this pull request
Jun 2, 2026
* Add factorial smc * Simplify + clean * Repeat -> tile * Tests * Add no_resampling and kalman-based test * Use build_filter, address Sahel's comments * add a factorize_initial_state arg (#245) * Some slight modifications to `factorialize_init_state` (#246) * Some slight modifications to factorialize_init_state * Update cuthbert/factorial/types.py Co-authored-by: Sahel Iqbal <sahel13miqbal@proton.me> --------- Co-authored-by: Sahel Iqbal <sahel13miqbal@proton.me> * fix scalar particle bug * fix ruff settings, lint and format * Revert "fix ruff settings, lint and format" This reverts commit 4079bc1. --------- Co-authored-by: Sahel Iqbal <sahel13miqbal@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Sahel13 Did some tidying up to make it a bit more functional and consistent naming (init and factorialize vs initial and factorize)
WDYT?
I think this should help solve #244 too