fix(lint): broaden generated tests/** ruff S-ignore for common test patterns - #245
Merged
Conversation
…atterns The v0.34.0 fan-out surfaced ruff S findings in real test code that the template's tests/** ignore did not cover, forcing per-repo triage: sklearn-wrap hit S105/S106/S107 (password-named fixtures), and kedro-dagster + kedro-azureml-pipeline hit S104/S108/S112 (bind-all-interfaces, hardcoded temp paths, try/except/continue). These are all legitimate in test code. Add S104/S105/S106/S107/S108/S112 to the template's tests/** per-file-ignore so future repos and fan-outs skip that triage. src/ still enforces every S rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Broadens the generated
tests/**ruffS-ignore withS104, S105, S106, S107, S108, S112.Why (evidence from the v0.34.0 fan-out)
Enabling ruff
Sfleet-wide (v0.33.0) surfacedSfindings in real test code that the template'stests/**ignore did not cover, forcing per-repo triage during the fan-out:S105/S106/S107— password-named test fixturesS104/S108/S112— bind-all-interfaces, hardcoded temp paths, try/except/continueS112— best-effort plugin-load loop in conftestAll are legitimate in test code (the same "tests may do insecure-looking things" philosophy behind the existing
S101/S110/S301/S311/S603/S607ignores). Adding them upstream means future repos and fan-outs skip this triage.src/still enforces everySrule.Scope
One line in
template/pyproject.toml.jinja. Config-only; fast suite green (383). This is the v0.35.0 follow-up to the security hardening work.