fix(ci): pin ossf/scorecard-action to a real tag (v2.4.4) - #247
Merged
Conversation
The Scorecard workflow shipped with ossf/scorecard-action@v2, but that action publishes no floating vN tag -- only vX.Y.Z. Every generated public repo's Scorecard run failed at load with 'unable to find version v2'. Pin to v2.4.4 (Renovate keeps it current). Also add test_expected_action_pins_actually_resolve_on_github (slow, network-gated): the existing pin test only checks self-consistency + the EXPECTED_ACTION_PINS map, so a non-existent tag passed every test and failed only at runtime. The new test resolves each pinned ref against GitHub so this cannot recur silently.
The new test failed in the full-suite CI job: that env has no GH_TOKEN, so every 'gh api' call returns an auth error, which the skip logic misread as 'pin does not resolve'. Fix: fail ONLY on a definitive 404/not-found; skip when a ref cannot be checked (unauthenticated gh, rate limit, or offline). Verified: passes locally with an authenticated gh, skips cleanly with none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scorecard workflow shipped with
ossf/scorecard-action@v2, which is not a real ref (the action publishes onlyvX.Y.Ztags), so every generated public repo's Scorecard run failed at load with "unable to find version v2". Pins tov2.4.4.The 7 fleet repos were already hotfixed directly on
mainto stop the red; this fixes the template so future generations + fan-outs are correct.Also adds
test_expected_action_pins_actually_resolve_on_github(slow, network-gated): the existing pin test checks self-consistency but not that a tag exists on GitHub, which is exactly how@v2shipped green. The new test resolves every pinned ref, closing that gap.