Skip to content

fix(string): handle emoji modifiers in previous grapheme breaks #12215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjh9714 wants to merge 2 commits into
base: develop
Choose a base branch
from
+9 −3
Open

fix(string): handle emoji modifiers in previous grapheme breaks #12215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e465bc7
fix: handle emoji modifiers in previous grapheme breaks
sjh9714 May 20, 2026
d4a6dbb
Merge branch 'develop' into fix-prev-grapheme-skin-tone-break
sjh9714 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ function prevGraphemeClusterBreak( str, fromIndex ) {
for ( i = 1; i <= idx; i++ ) {
// If the current character is part of a surrogate pair, move along...
if ( hasUTF16SurrogatePairAt( str, i-1 ) ) {
ans = i-2;
breaks.length = 0;
emoji.length = 0;
continue;
}
cp = codePointAt( str, i );
Expand Down
9 changes: 9 additions & 0 deletions lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,15 @@ tape( 'the function returns the previous grapheme break position in a specified
t.end();
});

tape( 'the function treats emoji modifier sequences as a single extended grapheme cluster', function test( t ) {
var out;

out = prevGraphemeClusterBreak( '👉🏿' );
t.strictEqual( out, -1, 'returns expected value' );

t.end();
});

tape( 'the function returns zero when the second argument is a negative integer (equivalent to clamping the second argument to zero)', function test( t ) {
var out;

Expand Down