feat: add lapack/base/dsptrf#13288
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
This sort of formatting is not particularly helpful. The purpose of A is to provide an easy visual representation of the matrix. This sort of layout puts the onus of visual reconstruction on the reader.
There was a problem hiding this comment.
You can avoid needing to create a closure by simply making pos( oa, sa, idx ) and passing in oa and sa explicitly at the call sites below. That is preferable due to how optimizing compilers work.
There was a problem hiding this comment.
| // Interchange rows and columns `kk` and `kp` in the leading submatrix `A(0:k-1,0:k-1)`... |
Is it actually 1:k or is that one-based indexing? If the latter, make sure docs reflect zero-based indexing; otherwise, that is going to be misleading for people reading the code.
There was a problem hiding this comment.
Same comments. Are the indices in these comments all using one-based indexing? It is not clear.
There was a problem hiding this comment.
Use temporary variables here and below. These indexing expressions are repetitive and make the expressions hard to read.
There was a problem hiding this comment.
You have a lot of repeated calculations here. Figure out a way to simplify and clean-up.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves none.
Description
This pull request:
lapack/base/dsptrfRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers