Skip to content

refactor: replace isProbability with inline range check in stats/base/dists/geometric/mgf #13386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −4
Draft

refactor: replace isProbability with inline range check in stats/base/dists/geometric/mgf #13386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/node_modules/@stdlib/stats/base/dists/geometric/mgf/lib/factory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
// MODULES //

var constantFunction = require( '@stdlib/utils/constant-function' );
var isProbability = require( '@stdlib/math/base/assert/is-probability' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var exp = require( '@stdlib/math/base/special/exp' );
var ln = require( '@stdlib/math/base/special/ln' );
Expand All @@ -41,7 +40,7 @@ var ln = require( '@stdlib/math/base/special/ln' );
* // returns ~0.783
*/
function factory( p ) {
if ( !isProbability( p ) ) {
if ( isnan( p ) || p < 0.0 || p > 1.0 ) {
return constantFunction( NaN );
}
return mgf;
Expand Down
3 changes: 1 addition & 2 deletions lib/node_modules/@stdlib/stats/base/dists/geometric/mgf/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

// MODULES //

var isProbability = require( '@stdlib/math/base/assert/is-probability' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var exp = require( '@stdlib/math/base/special/exp' );
var ln = require( '@stdlib/math/base/special/ln' );
Expand Down Expand Up @@ -67,7 +66,7 @@ var ln = require( '@stdlib/math/base/special/ln' );
function mgf( t, p ) {
var et;
var q;
if ( isnan( t ) || !isProbability( p ) ) {
if ( isnan( t ) || isnan( p ) || p < 0.0 || p > 1.0 ) {
return NaN;
}
q = 1.0 - p;
Expand Down